Contributing¶

Contributions are welcome, and they are greatly appreciated! Every little bit helps, and credit will always be given.

You can contribute in many ways:

Types of Contributions¶

Report Bugs¶

Report bugs at https://github.com/JarronL/pynrc/issues.

If you are reporting a bug, please include:

Your operating system name and version.
Any details about your local setup that might be helpful in troubleshooting.
Detailed steps to reproduce the bug.

Fix Bugs¶

Look through the GitHub issues for bugs. Anything tagged with “bug” and “help wanted” is open to whoever wants to implement it.

Implement Features¶

Look through the GitHub issues for features. Anything tagged with “enhancement” and “help wanted” is open to whoever wants to implement it.

Write Documentation¶

pyNRC could always use more documentation, whether as part of the official pyNRC docs, in docstrings, or even on the web in blog posts, articles, and such.

Submit Feedback¶

The best way to send feedback is to file an issue at https://github.com/JarronL/pynrc/issues.

If you are proposing a feature:

Explain in detail how it would work.
Keep the scope as narrow as possible, to make it easier to implement.
Remember that this is a volunteer-driven project, and that contributions are welcome :)

Pull Request Guidelines¶

Before you submit a pull request, check that it meets these guidelines:

The pull request should include tests.
If the pull request adds functionality, the docs should be updated. Put your new functionality into a function with a docstring.
The pull request should work for Python 3.7, 3.8, and 3.9 for PyPy. Check https://travis-ci.org/JarronL/pynrc/pull_requests and make sure that the tests pass for all supported Python versions.

Tips¶

To run a subset of tests:

$ py.test tests.test_pynrc

Deploying¶

A reminder for the maintainers on how to deploy. First, make sure the following packages are installed:

$ pip install sphinx_automodapi
$ conda install sphinx_rtd_theme
$ conda install nbsphinx
$ conda install twine
$ conda install docutils=0.16
$ conda install bump2version

Add entries to HISTORY.rst. Make sure all your changes are committed to git.
Update version using bumpversion, which automatically updates pynrc.version. Usage: bump2version [options] part [file], where “part” is either major, minor, or patch (e.g., major.minor.patch). See https://github.com/c4urself/bump2version for more details.
```
$ bumpversion patch
```
Generate documentation locally:
```
$ make docs
```
Push all updates to github and make sure readthedocs generates correctly before actually submitting the release.
Package a distribution and test upload the release to TestPyPI:
```
$ make release-test
```
If everything works without a hitch, then upload the release to PyPI:
```
$ make release
```
This command also tags the release on github. Make sure to have the command line token handy to enter as the requested password. Double-check stable release of readthedocs.

Todo

Release code to conda-forge. If you already have a conda-forge feedstock forked to your own GitHub account, first edit recipe/meta.yaml to update the version, hash, etc. To calculate the sha256 hash, run:
```
openssl dgst -sha256 path/to/package_name-0.1.1.tar.gz
```
Then, commit and push the yaml file to GitHub:
```
git pull upstream master
git add --all
git commit -m 'version bump to v0.1.1'
git push -u origin master
```
Finally, issue a pull request to conda-forge.

At end of all this, double-check the build environments at https://readthedocs.org/projects/pynrc/builds/. For whatever reason, it is common for there to be an OSError and the build to fail. Resetting the environment at https://readthedocs.org/projects/pynrc/versions/ tends to fix this issue. Build times take about 5 minutes.